Array2: Struct Array #217
Merged
Array2: Struct Array #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
reviewed
Apr 8, 2024
vortex-array/src/ptype.rs
Outdated
| use vortex_error::{vortex_err, VortexError, VortexResult}; | ||
| use vortex_schema::DType::*; | ||
| use vortex_schema::{DType, FloatWidth, IntWidth}; | ||
|
|
||
| use crate::scalar::{PScalar, Scalar}; | ||
|
|
||
| #[cfg_attr(feature = "serde", derive(Serialize, Deserialize))] |
There was a problem hiding this comment.
you should kill the custom ptype serde?
robert3005
reviewed
Apr 8, 2024
| fn accept(&self, visitor: &mut dyn ArrayVisitor) -> VortexResult<()>; | ||
| } | ||
|
|
||
| // TODO(ngates): maybe we make this more like the inverse of TryFromParts? |
There was a problem hiding this comment.
I tihnk we should? It's easier to pattern match then
robert3005
reviewed
Apr 8, 2024
| total_size: usize, | ||
| } | ||
|
|
||
| /// TODO(ngates): I think we want to go back to the old explicit style. It gives arrays more |
There was a problem hiding this comment.
we could have this as a default impl?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: