Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary stats for arrays containing null bytes and match stats behaviour between varbin and primitive arrays #233

Merged
merged 5 commits into from
Apr 13, 2024

Conversation

robert3005
Copy link
Member

@robert3005 robert3005 commented Apr 13, 2024

Made the bevaiour match the primitive stats as well where min/max is null if whole array is null

@robert3005 robert3005 changed the title Fix binary stats for arrays containing null bytes Fix binary stats for arrays containing null bytes and match stats behaviour between varbin and primitive arrays Apr 13, 2024
@robert3005 robert3005 enabled auto-merge (squash) April 13, 2024 00:21
vortex-array/src/array/primitive/stats.rs Outdated Show resolved Hide resolved
vortex-array/src/array/primitive/stats.rs Show resolved Hide resolved
vortex-array/src/array/varbin/stats.rs Outdated Show resolved Hide resolved
@robert3005 robert3005 merged commit 4e85688 into develop Apr 13, 2024
2 checks passed
@robert3005 robert3005 deleted the rk/binary-stats branch April 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants