Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Array comparison compute function #336

Merged
merged 10 commits into from
May 21, 2024
Merged

Array comparison compute function #336

merged 10 commits into from
May 21, 2024

Conversation

jdcasale
Copy link
Contributor

Necessary for implementing right-hand-side field references in array predicates

@jdcasale
Copy link
Contributor Author

jdcasale commented May 20, 2024

Unsurprisingly, the bool implementation is ~100x faster than the primitive version for a simple benchmark case

compare_arrays/compare_int
                        time:   [48.390 ms 48.540 ms 48.711 ms]
Found 6 outliers among 100 measurements (6.00%)
  4 (4.00%) low mild
  2 (2.00%) high severe

compare_arrays/compare_bool
                        time:   [433.67 µs 438.93 µs 443.93 µs]

@jdcasale jdcasale force-pushed the jc/compare-arrays branch from 170e2a4 to 28f600c Compare May 20, 2024 15:48
@jdcasale jdcasale marked this pull request as ready for review May 20, 2024 15:50
vortex-array/src/array/bool/compute/compare.rs Outdated Show resolved Hide resolved
vortex-array/src/array/bool/compute/compare.rs Outdated Show resolved Hide resolved
vortex-array/src/array/bool/compute/compare.rs Outdated Show resolved Hide resolved
vortex-array/src/array/bool/compute/compare.rs Outdated Show resolved Hide resolved
vortex-array/src/array/bool/compute/compare.rs Outdated Show resolved Hide resolved
vortex-array/src/array/bool/compute/compare.rs Outdated Show resolved Hide resolved
@jdcasale jdcasale requested a review from gatesn May 21, 2024 09:36
@jdcasale jdcasale enabled auto-merge (squash) May 21, 2024 09:48
@jdcasale jdcasale merged commit 48ec35c into develop May 21, 2024
3 checks passed
@jdcasale jdcasale deleted the jc/compare-arrays branch May 21, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants