fix: ID collision between vortex.ext and fastlanes.delta #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
approved these changes
Sep 19, 2024
|
Really need a compile time test to assert all of them are unique |
lwwmanning
approved these changes
Sep 19, 2024
robert3005
reviewed
Sep 19, 2024
|
|
||
| #[doc = "Encoding ID constants for all Vortex-provided encodings"] | ||
| #[allow(dead_code)] | ||
| pub mod ids { |
There was a problem hiding this comment.
really wanted to avoid this being in the main package but not sure if there's a way that this would be useful otherwise
There was a problem hiding this comment.
we can put it upstream of vortex-array, but it's not particularly useful if we can't reference it in the ~half of encodings that are in that crate
There was a problem hiding this comment.
IMO just put it in the README. Document the reserved range for Vortex, and the range for "custom" extensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both were using ID code 16. I left
fastlanes.deltaas 16 to be contiguous with the other fastlanes codes, and pushed extension to the end