Create shared UIElement finders #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corrado4eyes
changed the title
… map to set application arguments.
…ift. Remove enum on kotlin side and update test runners
dasdranagon
reviewed
Jan 3, 2024
| let scrollItem = app.staticTexts[scrollViewItemIndex] | ||
| XCTAssert(scrollItem.waitForExistence(timeout: 0.1)) | ||
|
|
||
| // Cross-platform implementation |
There was a problem hiding this comment.
Not clear what it means. It is a swift file, how does it relate to cross-platform?
dasdranagon
reviewed
Jan 3, 2024
| @@ -89,6 +90,7 @@ | |||
| 48B350D3EB640C8B7B253753 /* UninitializedObservable.generated.swift */ = {isa = PBXFileReference; explicitFileType = sourcecode.swift; path = UninitializedObservable.generated.swift; sourceTree = "<group>"; }; | |||
| 4DEA2654EFE69B013946D9B0 /* Pods-CucumberTests.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-CucumberTests.release.xcconfig"; path = "Target Support Files/Pods-CucumberTests/Pods-CucumberTests.release.xcconfig"; sourceTree = "<group>"; }; | |||
| 5416DF2E8BB6BE190C0431AF /* NavigationBarColor.generated.swift */ = {isa = PBXFileReference; explicitFileType = sourcecode.swift; path = NavigationBarColor.generated.swift; sourceTree = "<group>"; }; | |||
| 640CC3C72AB49ECA003E3D8C /* Node+Extensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Node+Extensions.swift"; sourceTree = "<group>"; }; | |||
There was a problem hiding this comment.
I would use xcodegen. changes in pbxproj is difficult to review
dasdranagon
reviewed
Jan 3, 2024
| override fun swipeUntilKey(key: Any, velocity: Float?) { | ||
| try { | ||
| node.performScrollToKey(key) | ||
| } catch (e: IllegalArgumentException) { |
There was a problem hiding this comment.
I would println the error so it's obvious that an exception was thrown
dasdranagon
reviewed
Jan 3, 2024
| @@ -15,11 +15,11 @@ import org.koin.dsl.module | |||
| class LoginViewModelTest : KoinUIThreadViewModelTest<LoginViewModelTest.KoinContext, LoginViewModel>() { | |||
| class KoinContext : KoinViewModelTestContext<LoginViewModel>( | |||
| module { | |||
| single<AuthService> { AuthServiceMock() } | |||
| single<AuthService> { AuthServiceMock(getOrNull()) } | |||
There was a problem hiding this comment.
I would add a name for the parameter. If you have only get it's not clear what kind of argument you are passing.
dasdranagon
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#33
#34
#35