Skip to content

Commit

Permalink
Merge remote-tracking branch 'GitLiveApp/master' into feature/field-v…
Browse files Browse the repository at this point in the history
…alue-encoding
  • Loading branch information
Daeda88 committed Sep 4, 2024
2 parents ebe3198 + 00968f7 commit 5332e61
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 12 deletions.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -278,9 +278,13 @@ These properties are only accessible from the equivalent target's source set. Fo
.build()
```

### Running on Android

On android, some modules (`config`) require you to enable [Core library desugaring](https://developer.android.com/studio/write/java8-support#library-desugaring) if you have a *minSDK lower than API 26*.

### Running on iOS

On iOS the official [Firebase iOS SDK](https://github.com/firebase/firebase-ios-sdk) in not linked as a transtive dependency. Therefore, any project using this SDK needs to link the actual Firestore SDK as well. This can be done through your preferred installation method (Cocoapods/SPM).
On iOS the official [Firebase iOS SDK](https://github.com/firebase/firebase-ios-sdk) in not linked as a transitive dependency. Therefore, any project using this SDK needs to link the actual Firestore SDK as well. This can be done through your preferred installation method (Cocoapods/SPM).

Similarly, tests require linking as well. Make sure to add the required frameworks to the search path of your test targets. This can be done by specifying a `cocoapods` block in your `build.gradle`:
```kotlin
Expand Down
4 changes: 2 additions & 2 deletions firebase-common-internal/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@gitlive/firebase-common-internal",
"version": "2.0.0",
"version": "2.1.0",
"description": "Wrapper around firebase for usage in Kotlin Multiplatform projects",
"main": "firebase-common-internal.js",
"scripts": {
Expand All @@ -23,7 +23,7 @@
},
"homepage": "https://github.com/GitLiveApp/firebase-kotlin-multiplatform-sdk",
"dependencies": {
"@gitlive/firebase-common": "2.0.0",
"@gitlive/firebase-common": "2.1.0",
"firebase": "9.19.1",
"kotlin": "1.8.20",
"kotlinx-coroutines-core": "1.6.4",
Expand Down
5 changes: 0 additions & 5 deletions firebase-config/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ android {
}

compileOptions {
isCoreLibraryDesugaringEnabled = true
sourceCompatibility = JavaVersion.VERSION_17
targetCompatibility = JavaVersion.VERSION_17
}
Expand All @@ -45,10 +44,6 @@ android {
}
}

dependencies {
coreLibraryDesugaring(libs.android.desugarjdk)
}

val supportIosTarget = project.property("skipIosTarget") != "true"

kotlin {
Expand Down
6 changes: 2 additions & 4 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[versions]
agp = "8.5.2"
agp = "8.6.0"
androidx-test-core = "1.6.1"
androidx-test-junit = "1.2.1"
androidx-test-runner = "1.6.2"
Expand All @@ -10,7 +10,7 @@ gson = "2.11.0"
junit = "4.13.2"
kotlin = "2.0.20"
kotlinx-coroutines = "1.9.0-RC.2"
kotlinx-serialization = "1.7.1"
kotlinx-serialization = "1.7.2"
kotlinx-binarycompatibilityvalidator = "0.16.3"
kotlinx-datetime = "0.6.1"
kotlinter = "4.4.1"
Expand All @@ -20,7 +20,6 @@ firebase-cocoapods = "11.1.0"
ios-deploymentTarget = "13.0"
test-logger-plugin = "4.0.0"
dokka = "1.9.20"
desugar-libs = "2.1.1"

[libraries]
android-gradle-plugin = { module = "com.android.tools.build:gradle", version.ref = "agp" }
Expand Down Expand Up @@ -50,7 +49,6 @@ kotlinx-coroutines-swing = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-
kotlinx-serialization-core = { module = "org.jetbrains.kotlinx:kotlinx-serialization-core", version.ref = "kotlinx-serialization" }
kotlinx-datetime = { module = "org.jetbrains.kotlinx:kotlinx-datetime", version.ref = "kotlinx-datetime" }
dokka-base = { module = "org.jetbrains.dokka:dokka-base", version.ref = "dokka" }
android-desugarjdk = { module = "com.android.tools:desugar_jdk_libs", version.ref = "desugar-libs" }

[plugins]
android-application = { id = "com.android.application", version.ref = "agp" }
Expand Down

0 comments on commit 5332e61

Please sign in to comment.