Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group form: floppy disk icon removed #169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iqqmuT
Copy link
Contributor

@iqqmuT iqqmuT commented Jun 16, 2024

  • floppy disk is not a modern icon
  • some users might associate floppy disk icon to saving data to a local device but here we are saving data in cloud
  • no icon needed, coloring indicates it is the submit button
  • if save button has an icon, then cancel button should have also for symmetry

Refers #132

@dcbr
Copy link
Contributor

dcbr commented Jun 17, 2024

I don't really agree with your first two points, see for example following discussions on this topic (from 13 years ago, yet "floppy disk" save icons are still in use even today!): https://stackoverflow.com/questions/1019573/save-icon-still-a-floppy-disk and https://ux.stackexchange.com/questions/3117/save-icon-is-the-floppy-disk-icon-dead.

  • no icon needed, coloring indicates it is the submit button

Fair enough

  • if save button has an icon, then cancel button should have also for symmetry

But I like this latter approach more personally.

@aloxe
Copy link

aloxe commented Jun 17, 2024

  • floppy disk is not a modern icon

That's right, it was added in Unicode for version 6.0 in 2010. Along with the 📼 Videocassette, 📤 input and output trays, 📠 fax machine, 📟 Pager and 📯 postal horn. The postal horn is maybe the oldest unused device but the symbol is still used in some countries as a sign for post offices and postal services.

@iqqmuT
Copy link
Contributor Author

iqqmuT commented Jun 17, 2024

Thank you for your good points. Feel free to close this pull request. Perhaps the floppy disk icon can be re-evaluated in 10 years or so. 😊

@pktiuk
Copy link
Contributor

pktiuk commented Jun 18, 2024

I also disagree with these statements.
Floppy disc is currently associated with saving.
Just write save icon in google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants