Add ability to write math expression in amount field #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Invalid expression in amount field was submitted, it would throw an error. It has been wrapped in try block.
|
I have updated the formatting issues that was failing the Prettier check. |
|
@scastiel hello, I have fixed the merge problems as well. Can you check if you are free? My PR is a complete mess btw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating new expenses, currently there is no support to write mathematical expressions.
My solution includes a package math-expression-evaluator.
On change in the amount field, it tries to evaluate the string and shows the evaluated value if correct and 'Invalid expression' otherwise.
The evaluated amount is shown below the input box.
'This is a reimbursement' is renamed to 'Reimbursement' and shifted to the right side of the total value field.
Fixes #183