Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PAPP-34742 Add a max results per page and a pagination parameter for "find artifacts" action #25

Merged
merged 17 commits into from
Sep 24, 2024

Conversation

alexa-phantom
Copy link
Contributor

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)


Thanks for contributing!

@alexa-phantom alexa-phantom force-pushed the soarhelp-3820_automation_user_fail branch from 319c6a6 to e6b9a9f Compare September 23, 2024 18:59
@alexa-phantom alexa-phantom force-pushed the soarhelp-3820_automation_user_fail branch from d9b58d2 to d175735 Compare September 23, 2024 19:26
@alexa-phantom alexa-phantom force-pushed the soarhelp-3820_automation_user_fail branch from 5f04b3e to a98e4cb Compare September 23, 2024 22:32
@alexa-phantom alexa-phantom force-pushed the soarhelp-3820_automation_user_fail branch from f51c59b to d053bf7 Compare September 24, 2024 05:11
Copy link

@bbielinski-splunk bbielinski-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving not to block the release but could you please see my comment and also check why tests are failing?

phantom_connector.py Show resolved Hide resolved
phantom_connector.py Show resolved Hide resolved
phantom_connector.py Show resolved Hide resolved
phantom_connector.py Show resolved Hide resolved
phantom_connector.py Show resolved Hide resolved
@ishans-crest ishans-crest merged commit 726c7c4 into next Sep 24, 2024
6 of 8 checks passed
@ishans-crest ishans-crest deleted the soarhelp-3820_automation_user_fail branch September 24, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants