Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update port from 5000 to 5001 for server #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

artemrys
Copy link
Member

Updating port from 5000 to 5001 for server to unblock folks who run on a newer macOS version.

@artemrys
Copy link
Member Author

@vtsvetkov-splunk can you please try to run this branch in your environment and see if this PR fixes it for you?

@hetangmodi-crest
Copy link
Collaborator

hetangmodi-crest commented Nov 21, 2024

Perhaps, can this solution be tried instead, or if we can change the flask server port as well, just to keep all the ports in parity?
Changing the port doesn't concern us either way.

Copy link
Collaborator

@vtsvetkov-splunk vtsvetkov-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, but I don't see the reason to expose this port to the host machine. We can safely remove ports from docker compose and EXPOSE from Dockerfile

It will be still accessible by the splunk container

@vtsvetkov-splunk
Copy link
Collaborator

Potentially may be superseded by #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants