Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liveness Probe and Readiness Probe with Defaults #111

Merged

Conversation

hjwalt
Copy link
Contributor

@hjwalt hjwalt commented Sep 22, 2021

For issue #105 . @regadas can I get your review? This is my first time contributing with golang (usually coding with Java).

@hjwalt hjwalt force-pushed the feature/liveness-readiness-probe-in-crd branch from 400b62e to 6f45e27 Compare September 22, 2021 12:32
Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjwalt Thanks for this!

Copy link
Contributor

@regadas regadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@regadas regadas merged commit 181693b into spotify:master Sep 24, 2021
@hjwalt
Copy link
Contributor Author

hjwalt commented Sep 24, 2021

Thank you for supporting the project @regadas !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants