Rename upcoming deprecated Lifecycle methods (#214)

* rename lifecycle methods in src * update examples * fix weird prettier stuff
spotify · Jan 29, 2020 · 5044ea0 · 5044ea0
1 parent 5fa4310
commit 5044ea0
Show file tree

Hide file tree

Showing 7 changed files with 20 additions and 13 deletions.
diff --git a/docs/src/docs/PieChart/examples/PieChart.js.example b/docs/src/docs/PieChart/examples/PieChart.js.example
@@ -11,7 +11,7 @@ class PieChartExample extends React.Component {
     this.setState({ sinVal });
   };
 
-  componentWillMount() {
+  UNSAFE_componentWillMount() {
     this._interval = setInterval(this._animateValue, 20);
   }
   componentWillUnmount() {

diff --git a/docs/src/docs/TreeMap/examples/AnimatedTreeMap.js.example b/docs/src/docs/TreeMap/examples/AnimatedTreeMap.js.example
@@ -8,7 +8,7 @@ class AnimatedTreeMapExample extends React.Component {
       this.setState({getValue: "size"});
   };
 
-  componentWillMount() {
+  UNSAFE_componentWillMount() {
     this._interval = setInterval(this._animateValue, 1000);
     this._data = {
       children: _.range(1, 5).map(n => ({

diff --git a/src/KernelDensityEstimation.js b/src/KernelDensityEstimation.js
@@ -71,10 +71,10 @@ class KernelDensityEstimation extends React.Component {
     return shouldUpdate;
   }
 
-  componentWillMount() {
+  UNSAFE_componentWillMount() {
     this.initKDE(this.props);
   }
-  componentWillReceiveProps(newProps) {
+  UNSAFE_componentWillReceiveProps(newProps) {
     this.initKDE(newProps);
   }
   initKDE(props) {

diff --git a/src/LineChart.js b/src/LineChart.js
@@ -54,11 +54,13 @@ export default class LineChart extends React.Component {
     return !xyPropsEqual(this.props, nextProps, ['lineStyle', 'lineClassName']);
   }
 
-  componentWillMount() {
+  /* eslint-disable-next-line camelcase */
+  UNSAFE_componentWillMount() {
     this.initBisector(this.props);
   }
 
-  componentWillReceiveProps(nextProps) {
+  /* eslint-disable-next-line camelcase */
+  UNSAFE_componentWillReceiveProps(nextProps) {
     this.initBisector(nextProps);
   }
 

diff --git a/src/SankeyDiagram.js b/src/SankeyDiagram.js
@@ -976,11 +976,13 @@ export default class SankeyDiagram extends React.Component {
     this._graph = enhanceGraph(sankeyGraph);
   }
 
-  componentWillMount() {
+  /* eslint-disable-next-line camelcase */
+  UNSAFE_componentWillMount() {
     this._makeSankeyGraph();
   }
 
-  componentWillReceiveProps(nextProps) {
+  /* eslint-disable-next-line camelcase */
+  UNSAFE_componentWillReceiveProps(nextProps) {
     // only update this._graph if a prop which affects the sankey layout has changed (most don't)
     const sankeyLayoutPropKeys = [
       'nodes',

diff --git a/src/TreeMap.js b/src/TreeMap.js
@@ -106,14 +106,18 @@ class TreeMap extends React.Component {
     NodeComponent: TreeMapNode,
     NodeLabelComponent: TreeMapNodeLabel,
   };
-  componentWillMount() {
+
+  /* eslint-disable-next-line camelcase */
+  UNSAFE_componentWillMount() {
     const { data } = this.props;
     // initialize the layout function
     this._tree = getTree(this.props);
     // clone the data because d3 mutates it!
     this._rootNode = getRootNode(cloneDeep(data), this.props);
   }
-  componentWillReceiveProps(newProps) {
+
+  /* eslint-disable-next-line camelcase */
+  UNSAFE_componentWillReceiveProps(newProps) {
     const { width, height, data, sticky } = this.props;
 
     // if height, width, or the data changes, or if the treemap is not sticky, re-initialize the layout function

diff --git a/src/ZoomContainer.js b/src/ZoomContainer.js
@@ -167,9 +167,8 @@ export default class ZoomContainer extends React.Component {
     if (this.props.onZoom) this.props.onZoom(nextZoomTransform, ...args);
   };
 
-  // React is deprecating componentWillReceiveProps, but it's pretty much necessary in this case
-  // TODO: change to UNSAFE_componentWillReceiveProps when upgrading React
-  componentWillReceiveProps(nextProps) {
+  /* eslint-disable-next-line camelcase */
+  UNSAFE_componentWillReceiveProps(nextProps) {
     if (this.props.controlled) {
       // if controlled component and zoom props have changed, apply the new zoom props to d3-zoom
       // (unbind handler first so as not to create infinite callback loop)