Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidirectional sync between spotify and tidal #107

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

joshrmcdaniel
Copy link
Collaborator

Features

  • Add ability to sync from tidal to spotify. This was implemented with backwards compatibility and utilizing the existing cache
  • Updated some type hints to conform to 3.10

Need to add test code

@joshrmcdaniel joshrmcdaniel self-assigned this Jan 19, 2025
@timrae
Copy link
Collaborator

timrae commented Feb 13, 2025

Hey @joshrmcdaniel, this is a pretty cool idea, but honestly speaking this is outside the scope of the script and I don't really have the time/energy to maintain this new code. I'm not totally against merging it, but in that case I'd rather it were in a self-contained folder src/tidal_to_spotify/*.py with it's own runner script and own config file / cache files. You could refactor out a src/common folder with shared code.

You'd need to maintain the new script yourself though. I haven't really thought about how much shared code there is. If there's a lot then the above suggestion might be a good one. If there's not then perhaps it could just go in its own repo, which might be slightly easier to maintain. If you'd like to go that route instead, you could put it in spotify2tidal/tidal_to_spotify if you like, or keep it in joshrmcdaniel/tidal_to_spotify if you prefer, it's up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants