Issue #41 - Migrate to use go-whatsup-client #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import `go-whatsup-client`. - Convert statuspage.io and slack `ReadStatus()` to take in the whatsup client and use it to get a status page. - Add service name and page URL as fields to the `statuspageio.ClientReader` struct. These are used when making the call via the whatsup client. - Pass a client into `GetOverview()` and create the appropriate struct based on the service type of the site. The client then gets passed into the `ReadStatus()` method associated with the struct type. - Clean out all the now dead code. - Polish up documentation. - Comment out goimports pre-commit hook for now. Seems like there isn't a Go 1.21 compatible version yet...
- Update go version in CI.
- Fix revive install.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-whatsup-client.ReadStatus()to take in the whatsup client and use it to get a status page.statuspageio.ClientReaderstruct. These are used when making the call via the whatsup client.GetOverview()and create the appropriate struct based on the service type of the site. The client then gets passed into theReadStatus()method associated with the struct type.