This repository has been archived by the owner on Nov 29, 2022. It is now read-only.
spring-projects/spring-security-saml#233 #461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates URLs to prefer the https protocol. Redirects are not followed to avoid accidentally expanding intentionally shortened URLs (i.e. if using a URL shortener). # Fixed URLs ## Fixed Success These URLs were switched to an https URL with a 2xx status. While the status was successful, your review is still recommended. * http://www.apache.org/licenses/ with 1 occurrences migrated to: https://www.apache.org/licenses/ ([https](https://www.apache.org/licenses/) result 200). * http://www.apache.org/licenses/LICENSE-2.0 with 132 occurrences migrated to: https://www.apache.org/licenses/LICENSE-2.0 ([https](https://www.apache.org/licenses/LICENSE-2.0) result 200).
…apache-license-history/1.0.x URL Cleanup
Always create a new chain to simplify branches. Use `chain.setFilters()` to avoid `UnsupportedOperationException`. Insert validation filters at the top of the chain. Ensure `setMetadataFilter` is called. Hopefully fixes: spring-attic#153 spring-attic#160 spring-attic#199
Fix initialisation of provider filters
Missing placeholder in debug messages (Obvious Fix)
Provide fixes to name verification of certs for trust engine when using TLSProtocolConfigurer and TLSProtocolSocketFactory which would always send a null in for trustedKey names. This caused the algorithm in BasicX509CredentialNameEvaluator to always reject any key over HTTPS regardless if that cert was imported into the keystore properly.
Provide fixes to name verification of certs for trust engine when using TLSProtocolConfigurer and TLSProtocolSocketFactory which would always send a null in for trustedKey names. This caused the algorithm in BasicX509CredentialNameEvaluator to always reject any key over HTTPS regardless if that cert was imported into the keystore properly.
Added a test to verify when TLSConfigurer is loaded and we are validating against chained certs things still work.
Make members protected so subclasses can work with the internals of this class better.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide fixes to name verification of certs for trust engine when using
TLSProtocolConfigurer and TLSProtocolSocketFactory which would always send a null
in for trustedKey names. This caused the algorithm in BasicX509CredentialNameEvaluator
to always reject any key over HTTPS regardless if that cert was imported into
the keystore properly.