Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spring Boot docs about Redis configuration #27

Closed
wants to merge 75 commits into from
Closed

Add Spring Boot docs about Redis configuration #27

wants to merge 75 commits into from

Conversation

zhangwt-cn
Copy link

@zhangwt-cn zhangwt-cn commented Oct 12, 2023

fix #26

Change

gregturn and others added 30 commits May 6, 2016 09:49
At the bottom of the document (above the footer), I added links to other guides that readers may find to be useful.
Jay Bryant and others added 22 commits January 16, 2020 16:18
I upgraded to Spring Boot 2.2.0, which necessitated upgrading the Gradle wrappers. Note that there are no tests in this guide.
Updated the Spring Boot version and the Gradle and Maven wrappers.

Also removed the Initializr image and updated the README to match.
Keeping the build files current and adding deep links to the Intializr.
Removed some redundancy in the links and added a manual option.
Also bumped the Spring Boot version to 2.4.3, to keep it current.
Boot 2.5.2 required a newer version of Gradle, too, so I updated it
to the current version (7.1 as of this writing).

Also added -initial or -complete to the artifactId field in the
pom.xml files.
by removing the build files from the README.
to fill in the project settings, as a convenience.
to 2.7.1 and 7.4.2, respectively.
to get onto the new major version of Spring Boot.
@Buzzardo
Copy link
Contributor

You seem to have included every file in the project. To add the link, only readme.adoc needs to be changed. To update the Spring Boot version (not in the original issue, but OK), you need to update only:

complete/build.gradle
complete/pom.xml
initial/build.gradle
initial/pom.xml

Please redo your commit to include only the relevant changes. Thanks.

@zhangwt-cn
Copy link
Author

You seem to have included every file in the project. To add the link, only readme.adoc needs to be changed. To update the Spring Boot version (not in the original issue, but OK), you need to update only:

complete/build.gradle complete/pom.xml initial/build.gradle initial/pom.xml

Please redo your commit to include only the relevant changes. Thanks.

👌I already redo commit

@zhangwt-cn zhangwt-cn changed the title Add Spring Boot docs about Redis configuration & Upgrade Spring Boot … Add Spring Boot docs about Redis configuration Oct 17, 2023
@Buzzardo
Copy link
Contributor

I still show 36 files changed and 75 commits. We need you to push only the relevant files, and we need it to be in a single commit. You can squash commits to make a single commit, but that's a bunch of work with 75 commits. It might be easier to make a new branch and make a new PR from that.

@zhangwt-cn zhangwt-cn closed this by deleting the head repository Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to the Spring Boot docs about Redis configuration.
8 participants