Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We do not send any CMP tracking requests when user is logged in as PU… #278

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

nickyanalytics
Copy link
Contributor

…R subscriber

@nickyanalytics nickyanalytics requested a review from mehakraza March 3, 2025 15:09
@@ -214,6 +217,10 @@
}
}

function notPurUser() {
return !!window.utag.data.user_hasPurSubscription2 || window.utag.data.user_hasPurSubscription2 && window.utag.data.user_hasPurSubscription2 == 'false';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return !!window.utag.data.user_hasPurSubscription2 is enough. It will cover for the false condition as well.

Copy link
Contributor

@mehakraza mehakraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 💯

Copy link
Contributor

@mehakraza mehakraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@nickyanalytics nickyanalytics merged commit a1e5cf9 into master Mar 14, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants