Sync with the orignal Spring Boot 3.4.0 version #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1658
With the current codebase, it does not seems to be needed anymore, so we disable it to provide better performances.
Made some variables as final
-Removed unused variables from few files. -Added null assertions in some tests. -Removed unnecessary throw exceptions.
- Update Spring Boot release, Checkstyle, Mysql. - Formatting pom.xml with sortpom-maven-plugin. - Rename README to standard file name. - Adding GitHub Action for Gradle.
- <fix>: use `equals` to replace `==` to compare `Integer` variable. - <delete>: remove redundant 'toLowerCase()' method and simplify pet lookup logic. - <update>: rewrite method `getName()` comments.
-<add>: add `@NotBlank` validation to pet's name. -<refactor>: delete useless code and add unit test to check duplicate Pet name validation logic. -<modify>: add `Id` to pet in unit test. -<refactor>: classify unit test. <modify>: adjust code format.
-<replace>: use `JpaRepository` to replace `Repository` in `OwnerRepository` class. -<remove1>: remove `save()` method. JpaRepository provides it by default. -<remove2>: remove `@Query` because in `Owner` class, the `@OneToMany` annotiation achieved `fetch` in query. -<refactor1>: use `Optional<Owner>` to recieve the result from `findById()`, and if is null, throw `IllegalArugmentExpection`. -<refactor2>: achieve the assert to judge return value in tests. -<add>: add name to `@author` tag.
<refactor>: remove useless logic cod. <refactor>: detele useless annotation which is provided by Jpa. <refactor>: refactor implement of `findByLastName`, use Jpa to simplify query.
Spring Boot 3.4 supports the webjars-locator-lite which in turn supports native images, so we are back to versionless URLs for webjars assets in templates.
-<modify>: remove `@Transactional`. -<add>: create unit-test file related to `PetValidator`. -<refactor>: move pet objects initialization to `@BeforeEach` setup.
Fixes #1522
Upgrade to Spring Boot 3.4.0 + disable gradle AOT
arey
force-pushed
the
feature/sync-canonical
branch
from
c8d03f1 to
8b7f844
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle Ahead-of-Time Processing has been disabled (still not supported by LangChain4j ?)