Polish #33566
Closed
Polish #33566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: task
nastae
approved these changes
Sep 19, 2024
sbrannen
reviewed
Sep 20, 2024
| @@ -59,7 +59,7 @@ class JdkClientHttpRequest extends AbstractClientHttpRequest { | |||
| private final HttpRequest.Builder builder; | |||
|
|
|||
|
|
|||
| public JdkClientHttpRequest(HttpMethod httpMethod, URI uri, DataBufferFactory bufferFactory, | |||
| JdkClientHttpRequest(HttpMethod httpMethod, URI uri, DataBufferFactory bufferFactory, | |||
There was a problem hiding this comment.
Although I fully understand the desire to remove public here, historically the code base often makes constructors public even if the enclosing type is not public.
Look at the other JdkClientHttpRequest implementation as well as neighboring classes for examples.
In light of that, I removed this change when merging the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR polishes a bit.