Add Jackson module to serialize/deserialize FieldValue #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Bodkin <james.bodkin@amphora.net>
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: enhancement
|
See #1174 for background. |
bclozel
changed the title
bclozel
added a commit
that referenced
this pull request
Apr 15, 2025
Prior to this commit, `ArgumentValue<T>` would mainly focus on the server-side support with the binding of arguments on Controller methods. With the introduction of this feature on the client in gh-1174, this commit reconsiders both the `ArgumentValue<T>` name and its package location to reflect the broader support. This commit deprecates `ArgumentValue<T>` in favor of `FieldValue<T>` with similar support. Closes gh-1187
bclozel
added a commit
that referenced
this pull request
Apr 15, 2025
The various GraphQL clients supported in this project automatically detect JSON codecs for reading/writing GraphQL requests as JSON payloads. If there is none detected, clients provide a default codec instance. This commit configures automatically the `GraphQlModule` from gh-1174 in default codecs and add integration tests for `FieldValue<T>` usage on the client side. This also improves the documentation around `FieldValue<T>` for both server and client side support. Closes gh-1190
bclozel
added a commit
that referenced
this pull request
Apr 15, 2025
bclozel
added
the
status: declined
|
This has been reverted in favor of exploring alternatives with #569 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.