New Feature - #1671 - Added Profile Page for Vets #1672
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2- Added method in repo to find vet by UUID of entity 3- Added new html template vetDetails.html that shows the details of Vet. 4- Adjusted the existing related unit tests to address the changes. 5- Added new unit tests in addition to util method to keep the UUID hidden. 6- Added UUID to data schemas and test data.
mosbat
force-pushed
the
mosbat/show-vet-profile-page
branch
from
933baae to
10e8e5f
Compare
mosbat
changed the title
|
The effort is appreciated, but I'm not sure we need this (and the usual policy on new features is to decline). Also the UUID change is kind of unnecessary as well as being invasive. |
No worries, I didn't know about the policy :) but thanks for letting me know! I had some time to kill :). You're right that the UUID change is not necessary; probably overkill. If you like I can close this PR and work a bit on the existing code base with smaller changes :) . |
|
Contributions always gratefully accepted. Thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1671