Minor Code Cleanup #1681
Merged
Minor Code Cleanup #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosbat
commented
Oct 4, 2024
mosbat
force-pushed
the
mosbat/1679-minor-code-cleanup
branch
from
52faeeb to
1ab4e2e
Compare
mosbat
force-pushed
the
mosbat/1679-minor-code-cleanup
branch
3 times, most recently
from
f0ac432 to
29f770a
Compare
dsyer
requested changes
Oct 7, 2024
src/main/java/org/springframework/samples/petclinic/owner/VisitController.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/samples/petclinic/PostgresIntegrationTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/samples/petclinic/vet/VetTests.java
Outdated
Show resolved
Hide resolved
|
@dsyer Please let me know if no further changes needed, so I'll squash the commits. I was told in the past to keep the commits to make it easier for reviewers to see the changes made :) |
|
If you can squash and rebase then force push now that would be helpful. Thank you. |
-Removed unused variables from few files. -Added null assertions in some tests. -Removed unnecessary throw exceptions.
mosbat
force-pushed
the
mosbat/1679-minor-code-cleanup
branch
from
44d48c5 to
0b2abfe
Compare
Done, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1679