Refactor to use JpaRepository default implement #1712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Refactor to use JpaRepository default implement
Description:
This PR refactor the
OwnerRepository
, implementing withJpaRepository
instead ofRepository
interface. Remove the rest@Query
inOwnerRepository
class. Also refactor code logic intest
andcontroller
files.Problem:
Use
JpaRepository
can auto-generate query, so need to delete theannotations
and also rename the method name, rebuild the code logic.Solution:
JpaRepository
to replaceRepository
inOwnerRepository
class.findByLastName
intofindByLastNameStartingWith
which can be auto-generate.Type of Change
Changes:
Local Test ScreenShot:
Additional Information:
This is just a part task to refactor the
OwnerRepository
withJpaRepository
. Also need to do the same thing withVetRepository
, but next step is to write more unit tests inPetControllerTests
.