Reorganizing the structure of the owner directory. #1736
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rent components have their own directories.
Related work item |
|
Pets and visits are part of the owner root entity in DDD terms. You can't separate them without breaking up the domain. |
|
Thank you for highlighting the design consideration. I'll be closing this pull request to stay aligned with the design principles of the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Pet and Visit were also kept in the same directory as the Owner, which is not following the modular design approach.
Current Solution
Broke down the components into their own directories for better management.
Benefits
Code readability can be enhanced.
Further, debugging can be done efficiently as we would be able to locate the directory where the bug needs to be resolved or where we need to do any sort of enhancement.