Enhanced owner search functionality #1777
Open
+14
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@APerumalRaj Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Signed-off-by: Perumal Raj A <[email protected]>
|
@APerumalRaj Thank you for signing the Contributor License Agreement! |
| @@ -53,7 +54,10 @@ public interface OwnerRepository extends JpaRepository<Owner, Integer> { | |||
| * @return a Collection of matching {@link Owner}s (or an empty Collection if none | |||
| * found) | |||
| */ | |||
| Page<Owner> findByLastNameStartingWith(String lastName, Pageable pageable); | |||
| // Page<Owner> findByLastNameStartingWith(String lastName, Pageable pageable); | |||
| @@ -124,10 +124,15 @@ private String addPaginationModel(int page, Model model, Page<Owner> paginated) | |||
| return "owners/ownersList"; | |||
| } | |||
|
|
|||
| private Page<Owner> findPaginatedForOwnersLastName(int page, String lastname) { | |||
| // private Page<Owner> findPaginatedForOwnersLastName(int page, String lastname) { | |||
There was a problem hiding this comment.
There is no need to have commented dead code.
Signed-off-by: Perumal Raj A <[email protected]>
|
@andrzejsydor I have made the requested changes. Please review and let me know if any further modifications are needed. Thanks! |
andrzejsydor
approved these changes
Feb 5, 2025
Signed-off-by: Perumal Raj A <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the owner search functionality to allow users to search by any part of the owner's name.
Previously, the search was restricted to matching the last name only.
LIKE.