This repository was archived by the owner on Mar 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
feature: add dynamic list of domains and update testnet #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tcar <[email protected]>
Signed-off-by: tcar <[email protected]>
Signed-off-by: tcar <[email protected]>
Signed-off-by: tcar <[email protected]>
Signed-off-by: tcar <[email protected]>
tcar121293
previously approved these changes
Feb 26, 2024
haochizzle
suggested changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few lines need to be updated.
we should also consider updating the docs to include instructions for _RPC_URL which now seem to be part of the .env file in the sygma-sdk examples.
...a-sdk/03-Quick-Start/07-Examples/01-Basic-ERC-20-Token-Transfers/02-EVM-Substrate-example.md
Outdated
Show resolved
Hide resolved
...a-sdk/03-Quick-Start/07-Examples/01-Basic-ERC-20-Token-Transfers/03-Substrate-EVM-example.md
Show resolved
Hide resolved
Signed-off-by: tcar <[email protected]>
haochizzle
reviewed
Feb 27, 2024
...a-sdk/03-Quick-Start/07-Examples/01-Basic-ERC-20-Token-Transfers/03-Substrate-EVM-example.md
Show resolved
Hide resolved
haochizzle
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some immediate changes required on the test net environment page because of removing two networks.
It also adds the first finalized component from draft PR #128 - dynamic domain table.
Details