This repository has been archived by the owner on Sep 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
p2p checkpoint #141
Open
chunningham
wants to merge
48
commits into
main
Choose a base branch
from
feat/p2p-checkpoint
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
p2p checkpoint #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunningham
force-pushed
the
feat/p2p-checkpoint
branch
3 times, most recently
from
April 5, 2023 15:18
60fe854
to
bff4ed0
Compare
chunningham
force-pushed
the
feat/p2p-checkpoint
branch
from
April 6, 2023 12:05
60630fb
to
622e92f
Compare
sbihel
approved these changes
Apr 19, 2023
sbihel
reviewed
Apr 26, 2023
franklovefrank
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a lot of p2p-related boilerplate as a reviewable prelude to p2p replication, while keeping the complicated parts-to-come out. Notably, it:
IntoTransport
trait)NetworkBehaviour
that will be built uponanyhow
errors as possible from core library componentsFurther development does not necessarily require that this be merged, but by building upon this state further PRs will include these changes, so this PR can act as a checkpoint to distinguish the boilerplate from the actual replication code.
some TODOs
Type
System Configuration
(Please delete options that are not relevant)
Runtime version(s):
Browser version(s):
Firmware version(s):
SDK version(s):
Diligence Checklist
(Please delete options that are not relevant)