Skip to content

Commit

Permalink
FRW-8773 Increased min php required ver to support php unit 11
Browse files Browse the repository at this point in the history
  • Loading branch information
olhalivitchuk committed Oct 18, 2024
2 parents d82267f + db44d3c commit 8ca1d11
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 7 deletions.
13 changes: 13 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
## PR Description
Add a meaningful description here that will let us know what you want to fix with this PR or what functionality you want to add.

## Steps before you submit a PR
- Please add tests for the code you add if it's possible.
- Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
- Add a `contribution-license-agreement.txt` file with the following content:
`I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker-sdk/phpstan-spryker/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.`

This is a mandatory step to make sure you are aware of the license agreement and agree to it. `HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH` is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

## Checklist
- [x] I agree with the Code Contribution License Agreement in CONTRIBUTING.md
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: [ '8.1', '8.2' ]
php-version: [ '8.2', '8.3' ]
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -54,7 +54,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php-version: [ '8.0' ]
php-version: [ '8.1' ]

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Spryker PHPStan Extensions
[![Build Status](https://github.com/spryker-sdk/phpstan-spryker/workflows/CI/badge.svg?branch=master)](https://github.com/spryker-sdk/phpstan-spryker/actions?query=workflow%3ACI+branch%3Amaster)
[![Minimum PHP Version](http://img.shields.io/badge/php-%3E%3D%208.0-8892BF.svg)](https://php.net/)
[![Minimum PHP Version](http://img.shields.io/badge/php-%3E%3D%208.1-8892BF.svg)](https://php.net/)
[![License](https://poser.pugx.org/spryker/code-sniffer/license.svg)](https://packagist.org/packages/spryker-sdk/phpstan-spryker)

* [PHPStan](https://github.com/phpstan/phpstan)
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}
],
"require": {
"php": ">=8.0",
"php": ">=8.2",
"phpunit/phpunit": "^11.4.0",
"phpstan/phpstan": "^1.0.0"
},
Expand Down
10 changes: 7 additions & 3 deletions tests/Type/Spryker/DynamicMethodMissingTypeExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
namespace SprykerSdk\PHPStanSpryker\Test\Rules\Spryker;

use PHPStan\Cache\Cache;
use PHPStan\Cache\CacheStorage;
use PHPStan\Reflection\Annotations\AnnotationsMethodsClassReflectionExtension;
use SprykerSdk\PHPStanSpryker\Type\Spryker\DynamicMethodMissingTypeExtension;
use PHPUnit\Framework\TestCase;
Expand All @@ -19,9 +20,12 @@ class DynamicMethodMissingTypeExtensionTest extends TestCase
*/
public function testInstance(): void
{
$extension = $this->getMockBuilder(AnnotationsMethodsClassReflectionExtension::class)->disableOriginalConstructor()->getMock();
$cache = $this->getMockBuilder(Cache::class)->disableOriginalConstructor()->getMock();
$instance = new DynamicMethodMissingTypeExtension($extension, $cache, 'test', []);
$instance = new DynamicMethodMissingTypeExtension(
new AnnotationsMethodsClassReflectionExtension(),
new Cache($this->createMock(CacheStorage::class)),
'test',
[]
);
$this->assertInstanceOf(DynamicMethodMissingTypeExtension::class, $instance);
}
}

0 comments on commit 8ca1d11

Please sign in to comment.