CC-15974: Code issues during phpstan 7|8 upgrades. (#9159)

CC-15974 Code issues during phpstan 7|8 upgrades

phpstan.neon

@@ -1,3 +1,3 @@
 parameters:
-    level: 6
+    level: 7
     checkMissingIterableValueType: false

src/Spryker/Zed/Locale/Business/Internal/Install/LocaleInstaller.php

@@ -58,10 +58,13 @@ protected function installLocales()
      */
     protected function executeInstallLocalesTransaction(): void
     {
+        /** @var resource $localeFile */
         $localeFile = fopen($this->localeFile, 'r');
 
         while (!feof($localeFile)) {
-            $locale = trim(fgets($localeFile));
+            /** @var string $locale */
+            $locale = fgets($localeFile);
+            $locale = trim($locale);
 
             $query = $this->localeQueryContainer->queryLocaleByName($locale);
 

src/Spryker/Zed/Locale/Business/Manager/LocaleManager.php

@@ -243,8 +243,10 @@ protected function getAvailableLocaleCollection(Store $store): array
         $localeTransfers = $this->localeRepository->getLocaleTransfersByLocaleNames($availableLocales);
 
         $indexedLocaleTransfers = $this->indexLocaleTransfersByLocalename($localeTransfers);
+        /** @var array<\Generated\Shared\Transfer\LocaleTransfer> $availableLocales */
+        $availableLocales = array_intersect_key(array_flip($availableLocales), $indexedLocaleTransfers);
 
-        return array_merge(array_flip($availableLocales), $indexedLocaleTransfers);
+        return array_merge($availableLocales, $indexedLocaleTransfers);
     }
 
     /**

src/Spryker/Zed/Locale/LocaleConfig.php

@@ -18,6 +18,7 @@ class LocaleConfig extends AbstractBundleConfig
      */
     public function getLocaleFile()
     {
+        /** @phpstan-var string */
         return realpath(__DIR__ . '/Business/Internal/Install/locales.txt');
     }
 }

tests/SprykerTest/Zed/Locale/Business/LocaleFacadeTest.php

@@ -46,6 +46,11 @@ class LocaleFacadeTest extends Unit
      */
     protected $localeNames = [];
 
+    /**
+     * @var \SprykerTest\Zed\Locale\LocaleBusinessTester
+     */
+    protected $tester;
+
     /**
      * @return void
      */
@@ -105,4 +110,17 @@ public function testCurrentLocaleIsChangeable(): void
         //Assert
         $this->assertSame($currentLocale->getLocaleName(), $newCurrentLocale->getLocaleName());
     }
+
+    /**
+     * @return void
+     */
+    public function testGetLocaleCollectionGetsLocalesFromStoreInstance(): void
+    {
+        // Act
+        $localeTransfers = $this->localeFacade->getLocaleCollection();
+
+        // Assert
+        $this->assertSame('en_US', array_keys($localeTransfers)[0]);
+        $this->assertSame('de_DE', array_keys($localeTransfers)[1]);
+    }
 }