Feature/otel optimisation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…exists on instrumentation boot
…lemetry into feature/otel-optimisation
| * @param \OpenTelemetry\SDK\Trace\SpanProcessorInterface $spanProcessor | ||
| * @param \OpenTelemetry\SDK\Resource\ResourceInfo $resource | ||
| * @param \OpenTelemetry\SDK\Common\Attribute\AttributesBuilderInterface $attributesBuilder | ||
| * @param array $links |
There was a problem hiding this comment.
i think you could specify an array type
| } | ||
|
|
||
| /** | ||
| * @return \OpenTelemetry\SDK\Trace\EventInterface[] |
There was a problem hiding this comment.
docblock is not consistent with dockblock in the defining of the $events property
| return $pExportTraceServiceRequest; | ||
| } | ||
|
|
||
| protected function convertResourceSpans(ResourceInfo $resource): ResourceSpans |
| return $pResourceSpans; | ||
| } | ||
|
|
||
| protected function convertScopeSpans(InstrumentationScopeInterface $instrumentationScope): ScopeSpans |
|
|
||
| /** | ||
| * @param Resource_|Span|Event|Link|InstrumentationScope $pElement | ||
| */ |
| $pElement->setDroppedAttributesCount($attributes->getDroppedAttributesCount()); | ||
| } | ||
|
|
||
| protected function convertSpanKind(int $kind): int |
| }; | ||
| } | ||
|
|
||
| protected function convertStatusCode(string $status): int |
| return StatusCode::STATUS_CODE_UNSET; | ||
| } | ||
|
|
||
| protected function convertSpan(SpanDataInterface $span): Span |
| return $pSpan; | ||
| } | ||
|
|
||
| protected static function traceFlags(SpanContextInterface $spanContext): int |
| { | ||
| /** | ||
| * @param string $spanId | ||
| * @return void |
There was a problem hiding this comment.
Suggested change
| * @return void | |
| * | |
| * @return void |
| $this->scheduledDelayNanos = $scheduledDelayMillis * 1_000_000; | ||
| } | ||
|
|
||
| protected function setMaxExportBatchSize(int $maxExportBatchSize, int $maxQueueSize): void |
| if ($cli) { | ||
| [$vendor, $bin, $application] = explode('/', $cli[0]); | ||
|
|
||
| if ($application === 'console') { |
There was a problem hiding this comment.
maybe it is good idea to strings such as argv and console to consts
| /** | ||
| * @return bool | ||
| */ | ||
| public function isEnabled(): bool |
There was a problem hiding this comment.
if it is a part of interface - pls skip this comment, otherwise this method is not necessary
src/Spryker/Service/Opentelemetry/Plugin/OpentelemetryMonitoringExtensionPlugin.php
Outdated
Show resolved
Hide resolved
src/Spryker/Service/Opentelemetry/Plugin/OpentelemetryMonitoringExtensionPlugin.php
Outdated
Show resolved
Hide resolved
asmarovydlo
reviewed
Dec 6, 2024
src/Spryker/Service/Opentelemetry/Instrumentation/Resource/CompositeResourceDetector.php
Outdated
Show resolved
Hide resolved
src/Spryker/Service/Opentelemetry/Instrumentation/Resource/CompositeResourceDetector.php
Show resolved
Hide resolved
src/Spryker/Service/Opentelemetry/Storage/ResourceNameStorageInterface.php
Show resolved
Hide resolved
src/Spryker/Zed/Opentelemetry/Business/Generator/ContentCreator/HookContentCreator.php
Outdated
Show resolved
Hide resolved
src/Spryker/Service/Opentelemetry/Plugin/OpentelemetryMonitoringExtensionPlugin.php
Outdated
Show resolved
Hide resolved
src/Spryker/Service/Opentelemetry/Plugin/OpentelemetryMonitoringExtensionPlugin.php
Outdated
Show resolved
Hide resolved
...Spryker/Service/Opentelemetry/Instrumentation/SpanProcessor/PostFilterBatchSpanProcessor.php
Show resolved
Hide resolved
asmarovydlo
previously approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add a meaningful description here that will let us know what you want to fix with this PR or what functionality you want to add.
Steps before you submit a PR
contribution-license-agreement.txtfile with the following content:I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/opentelemetry/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.This is a mandatory step to make sure you are aware of the license agreement and agree to it.
HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCHis a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.Checklist