-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Make QtBindingsNotFoundError
also inherit from ImportError
#413
Conversation
QtBindingsNotFoundError
inherit from ImportError
Seems like the tests are failing because QtPositioning is no longer included in |
I think is okay to skip it 👍 We could use as validation for the skip the Lines 9 to 13 in e7a7060
And adding in the reason the link to the PR you shared. Would you like to help adding the skip @CAM-Gerlach ? |
PR #414 is now merged! 🎉 |
358ee81
to
2f04efa
Compare
I've gone ahead and used GItHub's built-in "Update Branch" button to update this. @cbrnr , if you need to pull the changes locally, you'll need to do: git fetch origin
git reset --hard origin/qtbindingsnotfounderror |
QtBindingsNotFoundError
inherit from ImportError
QtBindingsNotFoundError
also inherit from ImportError
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cbrnr ! LGTM 👍
In addition to
PythonQtError
,QtBindingsNotFoundError
now also inherits fromImportError
. This should be easier to catch from outside than a genericRuntimeError
.Fixes #412.