Use Java target to 11 #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Dec 24, 2024
build.gradle
Outdated
| @@ -37,6 +39,17 @@ subprojects { | |||
|
|
|||
| kotlin.jvmToolchain(17) | |||
There was a problem hiding this comment.
I think we can remove this now, too? No reason to use such an ancient JDK. Developers should always be using the latest one.
There was a problem hiding this comment.
Do you mean it should use the user JDK (and the JDK defined in the GitHub Actions workflows, which is 17) or that I should upgrade it to 21?
There was a problem hiding this comment.
The former, the "user"/global JDK. It'll fail if someone tries to use older than 11, but otherwise our actions should be using 23.
There was a problem hiding this comment.
Removed and version upgraded to 23 on the workflows 👍
|
I think the token to publish snapshots to Sonatype is broken. |
It is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SqlDelight is forced to use Java 17 for the Gradle plugin due sql-psi
coredependency.This PR changes the target Java version to 11, but it still will use Java 17 in the toolchain as it has better build speed.
If you agree, upgrading the toolchain to Java 21 can be interesting as it should be faster.