Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in admin/common.php, error message was breaking the UI #8

Closed
wants to merge 1 commit into from

Conversation

unatarajan
Copy link

Overview / Task

  • Bug
  • Feature

Description

  • See attached screenshot, first error message only. The other 2 messages are fixed by installing dependencies using composer update.

Feature Validation / Bug Reproduction Steps

  1. Clone the SDK locally: git clone https://github.com/sqlitecloud/sqlitecloud-php.git.
  2. From the sqlitecloud-php/admin repo,
composer update # or composer install
cd admin
php -S localhost:8000
  1. Load the localhost link in browser: http://localhost:8000.

Screenshots & Videos

Screenshot 2024-07-30 at 1 50 10 PM

@unatarajan unatarajan requested a review from danielebriggi July 30, 2024 18:56
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php-admin-panel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2024 6:56pm

Copy link
Member

@danielebriggi danielebriggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to not update the composer.lock, can you please remove it? Then I check the failing test. Thank you

@unatarajan
Copy link
Author

Created a new PR without the composer.lock changes. Closing this PR.

@unatarajan unatarajan closed this Jul 31, 2024
@unatarajan unatarajan deleted the bug/admin-dash branch July 31, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants