XML Docs + WrapIdentifiers Unit Test #584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update SqlResult and Compiler to allow override classes derived from SqlResult
|
Closing this PR until further notice, xml documentation was merged on my end and included in the PR #594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML Tags to clarify usage of Opening/Closing Identifiers
Unit Test for
Compiler.WrapIdentifiersandReplaceIdentifierUnlessEscaped(the latter was just renamed according to the method name)Unit tests written to showcase issue talked about in #583
Note: These tests are currently PASSING, bbut I don't think they should be passing the escaped tests due to dropping the escape characters.