Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Dapper version & fix SqlResult errors #732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump Dapper version & fix SqlResult errors #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions QueryBuilder/Compilers/Compiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ protected Compiler()
/// <summary>
/// Whether the compiler supports the `SELECT ... FILTER` syntax
/// </summary>
/// <value></value>
/// <value></value>
public virtual bool SupportsFilterClause { get; set; } = false;

/// <summary>
/// If true the compiler will remove the SELECT clause for the query used inside WHERE EXISTS
/// </summary>
/// <value></value>
/// <value></value>
public virtual bool OmitSelectInsideExists { get; set; } = true;

protected virtual string SingleRowDummyTableName { get => null; }
Expand Down Expand Up @@ -229,7 +229,7 @@ protected virtual SqlResult CompileSelectQuery(Query query)

protected virtual SqlResult CompileAdHocQuery(AdHocTableFromClause adHoc)
{
var ctx = new SqlResult();
var ctx = new SqlResult(parameterPlaceholder, EscapeCharacter);

var row = "SELECT " + string.Join(", ", adHoc.Columns.Select(col => $"{parameterPlaceholder} AS {Wrap(col)}"));

Expand Down Expand Up @@ -295,7 +295,7 @@ protected virtual SqlResult CompileDeleteQuery(Query query)
}
else
{
// check if we have alias
// check if we have alias
if (fromClause is FromClause && !string.IsNullOrEmpty(fromClause.Alias))
{
ctx.RawSql = $"DELETE {Wrap(fromClause.Alias)} FROM {table} {joins}{where}";
Expand Down
2 changes: 1 addition & 1 deletion QueryBuilder/Compilers/SqlServerCompiler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ protected override string CompileBasicDateCondition(SqlResult ctx, BasicDateCond

protected override SqlResult CompileAdHocQuery(AdHocTableFromClause adHoc)
{
var ctx = new SqlResult();
var ctx = new SqlResult(parameterPlaceholder, EscapeCharacter);

var colNames = string.Join(", ", adHoc.Columns.Select(Wrap));

Expand Down
2 changes: 1 addition & 1 deletion SqlKata.Execution/SqlKata.Execution.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<ProjectReference Include="..\QueryBuilder\QueryBuilder.csproj" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="dapper" Version="2.0.123" />
<PackageReference Include="dapper" Version="2.1.35" />
<PackageReference Include="Humanizer.Core" Version="2.8.26" />
</ItemGroup>
</Project>
Loading