cmachak/bug-fix-tests (#23)

* fix extra DBResource in test * fix DatabricksResource construction
square · Feb 14, 2024 · ca3ef43 · ca3ef43
1 parent 96df31f
commit ca3ef43
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -3,7 +3,7 @@ name = "block-cascade"
 packages = [
     {include = "block_cascade"}
 ]
-version = "2.4.5"
+version = "2.4.6"
 description = "Library for model training in multi-cloud environment."
 readme = "README.md"
 authors = ["Block"]

diff --git a/tests/test_config.py b/tests/test_config.py
@@ -53,6 +53,7 @@ def gcp_resource(gcp_environment, gcp_machine_config):
 @pytest.fixture()
 def databricks_resource():
     return DatabricksResource(
+        storage_location="s3://test-bucket/cascade",
         worker_count=DatabricksAutoscaleConfig(min_workers=5, max_workers=10),
         cloud_pickle_by_value=["a", "b"],
     )
@@ -107,6 +108,7 @@ def test_databricks_resource(
     configuration = f"""
 {test_job_name}:
     type: DatabricksResource
+    storage_location: {databricks_resource.storage_location}    
     worker_count:
         min_workers: {databricks_resource.worker_count.min_workers}
         max_workers: {databricks_resource.worker_count.max_workers}

diff --git a/tests/test_databricks_executor.py b/tests/test_databricks_executor.py
@@ -6,8 +6,6 @@
 from block_cascade.executors.databricks.job import DatabricksJob
 from block_cascade.utils import wrapped_partial
 
-databricks_resource = DatabricksResource()
-
 # Mocks paths
 MOCK_CLUSTER_POLICY = (
     "block_cascade.executors.DatabricksExecutor.get_cluster_policy_id_from_policy_name"