allow spoon to show user defined png files in the report. #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dweebo
reviewed
Nov 29, 2017
| @@ -40,12 +40,14 @@ buildscript { | |||
| 'espressoContrib': 'com.android.support.test.espresso:espresso-contrib:2.2.2', | |||
| 'runner': 'com.android.support.test:runner:0.5', | |||
| 'rules': 'com.android.support.test:rules:0.5', | |||
| 'uiautomator': 'com.android.support.test.uiautomator:uiautomator-v18:2.1.1', | |||
There was a problem hiding this comment.
I would just add this dependency on the test-app, not to all modules
|
This is basically just a PR to take full screenshots (with dialogs) right? I can't see why else a user would want to add a png file. If you just want to attach an arbitrary file to a test you can already do that with So IMO I'd rather not have another Sounds like there was some support from Jake to use the code from https://github.com/jraska/Falcon |
|
See #502 as an alternative to this PR |
|
@dweebo thanks for the ref, ill look at these issues/PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow spoon to show user defined png files in the report.