Removes all Gradle internal APIs #3286
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostly filtering with 'org.gradle.api.internal'
oldergod
force-pushed
the
bquenaudon.2025-02-12.gradleinternal
branch
from
45afa57 to
2a596fe
Compare
oldergod
commented
Feb 12, 2025
| @@ -338,11 +339,38 @@ open class WireExtension( | |||
|
|
|||
| private fun srcFileOrConfiguration(jar: String) { | |||
There was a problem hiding this comment.
This method goes with our public API
/** Sets a local or a remote jar. Examples: "libs/protos.jar", or "com.example:protos:1.0.0". */
fun srcJar(jar: String) {
srcFileOrConfiguration(jar)
}
oldergod
commented
Feb 12, 2025
Comment on lines
+160
to
+161
| sourcePath = sourceInput.get().flatMap { it.toLocations(project, projectDirAsFile) }, | ||
| protoPath = protoInput.get().flatMap { it.toLocations(project, projectDirAsFile) }, |
There was a problem hiding this comment.
ooops
invocation of 'Task.project' at execution time is unsupported.
See https://docs.gradle.org/8.12.1/userguide/configuration_cache.html#config_cache:requirements:use_project_during_execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly filtering with 'org.gradle.api.internal'
closes #3244