set of changes related to new heldout-test feature (#300) #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pdreiter
commented
Apr 2, 2023
pdreiter
commented
- tested with and without heldout-test content
- IMPACT: Changes the TestOutcome, s.t. these two cases: (without heldout tests) and (failing heldout tests) are indiscernible
- tested with and without heldout-test content - IMPACT: Changes the TestOutcome, s.t. these two cases: (without heldout tests) and (failing heldout tests) are indiscernible
|
This is relevant to butrs-red-team-evaluation/issues/54 |
| if not self.__run_heldout_tests: | ||
| heldout = self.heldout_tests | ||
| valid_heldout = True if len(heldout)>0 else False | ||
|
|
There was a problem hiding this comment.
Definition of valid_heldout can be simplified:
valid_heldout = bool(heldout)Also, can we also get rid of 3/4 of the new lines to improve readability?
| @@ -70,6 +72,9 @@ def __init__(self, | |||
| # FIXME used the precomputed test ordering for now | |||
| self.__test_ordering: Sequence[Test] = list(self.__problem.tests) | |||
|
|
|||
| self.__heldout_tests: Sequence[Test] = list(self.__problem.heldout_tests) | |||
|
|
|||
There was a problem hiding this comment.
very minor quibble: remove 1/2 whitespace lines to improve readability
| @@ -138,12 +143,16 @@ def _filter_redundant_tests(self, | |||
| def _run_test(self, | |||
| container: ProgramContainer, | |||
| candidate: Candidate, | |||
| test: Test | |||
| test: Test, | |||
| heldout: bool = False | |||
There was a problem hiding this comment.
minor: can we make heldout a keyword-only argument to improve readability at caller sites?
test: Test,
*,
heldout: bool = False,
|
Based on conversation with @ChrisTimperley - an alternative strategy would be to use darjeeling as an interface to the docker container to evaluate patches. |
|
I'll be retooling this approach to reduce the impact to existing darjeeling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.