Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies in inactive buttons #206

Open
dpordomingo opened this issue Jul 11, 2019 · 4 comments
Open

Inconsistencies in inactive buttons #206

dpordomingo opened this issue Jul 11, 2019 · 4 comments
Assignees
@ricardobaeta
Labels
enhancement New feature or request needs more info Further information from author of issue is requested product-design Visual, branding, typography triage/needs-product-input This needs input from product

Comments

@dpordomingo
Copy link
Contributor

I'd apply the same "opacity change effect" to load and share buttons, to differentiate their "active" from "inactive" states, as done in search button.
image
@dpordomingo dpordomingo added the enhancement New feature or request label Jul 11, 2019
@dpordomingo dpordomingo mentioned this issue Jul 11, 2019
Merged
@se7entyse7en
Copy link
Contributor

Same as in #207.

@dpordomingo why is @ricardobaeta assigned to this? I guess that this should be in @src-d/product board and not in ours? Or this just means that you're asking @ricardobaeta to approve this change?

@se7entyse7en se7entyse7en added needs more info Further information from author of issue is requested product-design Visual, branding, typography labels Oct 18, 2019
@dpordomingo
Copy link
Contributor Author

Because it was caused by #204, and supposedly being approved/fixed by him.
But I think we can now un-assign, and reconsider it.

@se7entyse7en
Copy link
Contributor

If @ricardobaeta confirms we can consider this from next sprint. I'll add the label requiring product for now.

@se7entyse7en se7entyse7en added the triage/needs-product-input This needs input from product label Oct 23, 2019
@ricardobaeta
Copy link
Contributor

@se7entyse7en I'll update you on this next Monday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ricardobaeta ricardobaeta

Labels
enhancement New feature or request needs more info Further information from author of issue is requested product-design Visual, branding, typography triage/needs-product-input This needs input from product
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ricardobaeta @dpordomingo @se7entyse7en