This adds branding to the UAST Lab

[ricardobaeta]

Signed-off-by: Ricardo Baeta [email protected]

[carlosms]

The only problem I've found is the style for disabled buttons.

In here you can see the SEARCH button correctly changes the color when it is enabled/disabled. Well, the change is maybe too subtle, but it is there:

But for LOAD/SHARE there is not change in style when they are enabled/disabled. When I paste the url https://gist.githubusercontent.com/carlosms/77fe0df0b1b371b9b165abe984ea2560/raw/ab6037be92fb90f42b9468de17d3bcf2b7268d81/hello.java in the text field the only way to know they are active is the shadow on hover. The color does not change, like with SEARCH.

[ricardobaeta]

Thanks @carlosms for the catch! The latest commit 7cee8b0 fixes this bug.

[dpordomingo]

LGTM but a minor thing that could be addressed in a new issue/PR

readonly (unnactive) buttons has no the same styles in share button and search buttons.
Also, filled UAST Query input is different to filled Raw Gist Url input.

👇 both are innactive

👇 both are acrive

[carlosms]

Exactly, maybe I didn't explain myself in my previous comment, but the gif shows how LOAD and SHARE don't change the style for enabled/disabled, while SEARCH has this subtle change in color.

Since 7cee8b0 removes the shadow on hover for active buttons, now there is absolutely no visual cue to know if LOAD or SHARE are enabled/disabled.

[ricardobaeta]

@carlosms and @dpordomingo :) Thanks for really taking the time to point me out to the traits of this behaviour. I wasn't fully understanding the interaction before, and now I do and know how we can improve it.

Details of my latest changes:

1. The text on the input of the Raw Gist URL has now proper typography styling.
2. The buttons - LOAD & SHARE & SEARCH - have now a :hover effect when they're active.
3. A button should always provide visual feedback upon people's interaction - hover/click - despite being inactive. Having this in mind, I've added a subtle behaviour to these inactive buttons.

Solution 👇

[dpordomingo]

For me, the new change is enough to merge. We can iterate in another PR, considering the following issues:

• Inconsistencies in inactive buttons #206 Inconsistencies in inactive buttons
• Inconsistencies in auto-filled inputs #207 Inconsistencies in auto-filled inputs

[carlosms]

👍