Node 18 support

[versecafe]

Fixes #189

Just references crypto with an import instead of assuming in name space

+ import * as crypto from 'crypto';

  export function randomid(byteSize = 16) {
    const bytes = crypto.getRandomValues(new Uint8Array(byteSize));
    return base32hexnopad.encode(bytes).toLowerCase();
  }

[nichochar]

Indeed my cursory exploration of node18 compat only brought up this issue. I will do a bit of QA to make sure most of the functionality works correctly, but otherwise LGTM.

We're not heavily prioritizing earlier versions FYI, since we might want to use some recent features like replacing tsx with vanilla node with --experimental-strip-types.

However, if it's easy in the meantime, I'm all for compatibility.

[versecafe]

--experimental-strip-types is probably something I'd recommend avoiding until it's more stable unless you allow users on bun to run the TS proper, and find a solution for people on Deno, and it could be removed at any time

[benjreinhart]

This is used on the client in addition to the Node backend. What happens in that environment? Is vite smart enough to remove this from the compiled code, or does it try to do some sort of polyfill (e.g. the way webpack used to with crypto-browserify)?

[versecafe]

This should technically work Vite doesn't do a polyfil but ignores the import which should then cause it to end up using the global window crypto instance, or polyfills can be added if for some reason it's not but it does seem to be working

[benjreinhart]

I do not want us to use polyfills for something that exists natively. So assuming this drops the import then I'm stoked to get this working in node 18.

[benjreinhart]

I couldn't find anything in a quick scan of vite's docs. My only concern would be if vite were to include a polyfill in our build that we don't need since I don't want to blow up the client side code for no reason (like webpack would)

I'm going to assume the above isn't the case and approve, but if you have any references in the docs you can provide that'd be reassuring

[versecafe]

@benjreinhart it will give a warning of

[plugin:vite:resolve] [plugin vite:resolve] Module "crypto" has been externalized for browser compatibility, imported by "/Users/veronica/Projects/srcbook/packages/shared/dist/src/utils.js". See https://vitejs.dev/guide/troubleshooting.html#module-externalized-for-browser-compatibility for more details.

but this just means it'll fail if you try to call the node version of crypto on the browser since no pollyfill is used, but the isBrowser check means that on a browser it will always end up using globalThis.crypto which is built in

[nichochar]

Let's go! Thanks @versecafe 🔥 🚀