Drives Workbook And Worksheets- Combined Work #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
6 tasks
|
Yes, those are mine accounts. One is my private, second is from my job. Haven't notice on which one I'm committing. |
No problem. Thanks for contributing. I updated crates.io with these changes included. Version is 1.1.2 if your using the crate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jacek-kurlit
@JK-Kitopi
Are these two profiles the same person? I didn't notice until now it was two different GitHub accounts in the commits. Either way, thanks for getting these updated 🚀
It looks like your branch doesn't have the codgen run once the last commits were added. Its fine eitherway. I ran the codgen and needed to update the drives APIs anyway.
But I had to do it on a branch in this repository because I couldn't add them to your forked branch. Your commits are still in this branch as well.