Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a request pipeline and configuration for retries #469

Merged
merged 16 commits into from
Aug 14, 2024
Merged

Conversation

DevLazio
Copy link
Collaborator

Closes #421

@sreeise
Copy link
Owner

sreeise commented May 23, 2024

Hey @DevLazio this looks great. I apologize for not getting back to this sooner. I have been busy as of late.

This is my fault for not saying anything sooner, but version 2.0.0 is being released and you will probably have to deal with merge conflicts when merging master.

This is awesome though. I appreciate the hard work on this.

@sreeise
Copy link
Owner

sreeise commented May 27, 2024

@DevLazio Hopefully the merge conflicts are not too bad. Everything looks good to me and ready to merge once the conflicts have been resolved.

sreeise
sreeise previously approved these changes May 27, 2024
@sreeise sreeise added this to the 2.1.0 milestone May 27, 2024
@sreeise
Copy link
Owner

sreeise commented Aug 4, 2024

Working on the merge conflicts while @DevLazio is away to help out and try to get this merged.

@sreeise sreeise merged commit 804467c into master Aug 14, 2024
2 checks passed
@sreeise sreeise deleted the retries branch August 14, 2024 10:55
@Jeadie
Copy link

Jeadie commented Sep 2, 2024

This PR makes GraphClient no longer sync.

Jeadie added a commit to Jeadie/graph-rs-sdk that referenced this pull request Sep 2, 2024
Jeadie added a commit to Jeadie/graph-rs-sdk that referenced this pull request Sep 3, 2024
phillipleblanc pushed a commit to spiceai/graph-rs-sdk that referenced this pull request Sep 9, 2024
* Make `EnvironmentCredential::username_password_env` public

* Revert "Add a request pipeline and configuration for retries (sreeise#469)"

This reverts commit 804467c.

* Update public_client_application.rs

* Update graph.rs

* Update authorization_code_credential.rs

* Update authorization_code_credential.rs

* create 'From<AuthorizationCodeCredential> for PublicClientApplication<AuthorizationCodeCredential>'

* Revert "Revert "Add a request pipeline and configuration for retries (sreeise#469)""

This reverts commit 37e4eef.

* Move tower service setup to RequestHandler. Closes sreeise#491 (sreeise#494)

* Move tower service setup to RequestHandler. Closes sreeise#491

---------

Co-authored-by: Sean Reeise <[email protected]>
Jeadie added a commit to Jeadie/graph-rs-sdk that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry functionality
3 participants