Added NotNullOrZero Attribute + test + website modifications #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute is useful when Required is not enough because the value can't be zero either (Great for IDs)
|
Unfortunately this validator won't work client-side, so I'm not going to merge quite yet. Maybe you can create a client attribute adapter that uses both a "required" rule and a "non-zero" rule (currently a non-zero rule doesn't exist)? Also did you consider just doing something like [Required] along with [Min(1)]? |
|
Yes, I currently use Min(1) but have to change the message everytime (want to avoid) and it's not semantic enough (want to avoid). Will work on the client side and let you know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute is useful when Required is not enough because the value
can't be zero either (Great for IDs)