Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the TLS cert verification on https downloads #1693

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Nov 2, 2023

fix #1678

@steiler steiler requested a review from hellt November 6, 2023 07:32
@hellt hellt merged commit 67e87d5 into srl-labs:main Nov 6, 2023
20 checks passed
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1693 (d21d1d6) into main (29bf491) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1693   +/-   ##
=======================================
  Coverage   51.32%   51.32%           
=======================================
  Files         138      138           
  Lines       13357    13369   +12     
=======================================
+ Hits         6855     6862    +7     
- Misses       5742     5746    +4     
- Partials      760      761    +1     
Files Coverage Δ
utils/file.go 52.28% <100.00%> (+3.09%) ⬆️

... and 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not enforce valid TLS for remote startup configs
2 participants