Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup TopoFileLoading #2226

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Dedup TopoFileLoading #2226

merged 2 commits into from
Oct 10, 2024

Conversation

steiler
Copy link
Collaborator

@steiler steiler commented Oct 10, 2024

Related to #2225 this dedups the code for loading topologies, where we've had a seperate implementation for the Destroy action.

@steiler steiler requested a review from hellt October 10, 2024 07:46
@hellt
Copy link
Member

hellt commented Oct 10, 2024

great catch. ty!

@hellt hellt merged commit 99a6b5d into main Oct 10, 2024
64 checks passed
@hellt hellt deleted the DestroyUseLoadTopologyFromFile branch October 10, 2024 09:27
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.55%. Comparing base (3dea806) to head (4d3e872).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/destroy.go 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2226      +/-   ##
==========================================
+ Coverage   51.54%   51.55%   +0.01%     
==========================================
  Files         171      171              
  Lines       12625    12617       -8     
==========================================
- Hits         6507     6505       -2     
+ Misses       5211     5208       -3     
+ Partials      907      904       -3     
Files with missing lines Coverage Δ
cmd/destroy.go 79.46% <66.66%> (+3.63%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants