Change management interface on IOL Layer 2 images from Vlan0 #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to Ethernet 0/0. While at it, get rid of any specific SVI configuration. Please note that the order of configurations statements is important.
kaelemc
reviewed
Oct 15, 2024
|
LGTM 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2235 +/- ##
==========================================
- Coverage 51.98% 51.94% -0.04%
==========================================
Files 172 172
Lines 12658 12658
==========================================
- Hits 6580 6575 -5
- Misses 5171 5175 +4
- Partials 907 908 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change management interface on IOL Layer 2 images from Vlan0 to Ethernet 0/0. While at it, get rid of any specific SVI configuration. Please note that the order of configurations statements is important.
When testing, please allocate enough time before trying to ssh into the layer 2 iol devices. Its initialization time is significantly higher then that of layer 3 iol devices.
The modification where tested both with containerlab and with the work in progress to support iol image in networklab through it's containerlab backed.