Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for __clabNodeName__ magic var #2257

Merged
merged 4 commits into from
Jan 3, 2025

move doc section closer to the path-based startup configs

eb74eee
Select commit
Loading
Failed to load commit list.
Merged

adds support for __clabNodeName__ magic var #2257

move doc section closer to the path-based startup configs
eb74eee
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 3, 2025 in 0s

51.86% (+0.68%) compared to 9e96472

View this Pull Request on Codecov

51.86% (+0.68%) compared to 9e96472

Details

Codecov Report

Attention: Patch coverage is 12.00000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 51.86%. Comparing base (9e96472) to head (eb74eee).
Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
mocks/mocknodes/default_node.go 0.00% 18 Missing ⚠️
mocks/mocknodes/node.go 0.00% 3 Missing ⚠️
mocks/mockruntime/runtime.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2257      +/-   ##
==========================================
+ Coverage   51.18%   51.86%   +0.68%     
==========================================
  Files         172      172              
  Lines       16689    17256     +567     
==========================================
+ Hits         8542     8950     +408     
- Misses       7235     7366     +131     
- Partials      912      940      +28     
Files with missing lines Coverage Δ
clab/config.go 67.69% <100.00%> (+1.03%) ⬆️
mocks/mockruntime/runtime.go 10.22% <0.00%> (-0.38%) ⬇️
mocks/mocknodes/node.go 5.12% <0.00%> (ø)
mocks/mocknodes/default_node.go 0.00% <0.00%> (ø)

... and 58 files with indirect coverage changes