Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display link tags for LAGs more properly #2306

Merged
merged 2 commits into from
Dec 12, 2024
Merged

Display link tags for LAGs more properly #2306

merged 2 commits into from
Dec 12, 2024

Conversation

jkary
Copy link
Contributor

@jkary jkary commented Nov 19, 2024

This request contains a fix for the GitHub issue 2224. The fix focuses on the separation of labels for multiple links between the same two nodes. There appears to be the following other issues:

  1. Popup labels for a link don't appear in the right place and sometimes shows the wrong link.
  2. Horizontal and vertical layouts appear to have the opposite effect.

As this is my first commit, please help me understand if I am doing something wrong.

Jason

fix #2224

* Updated javascript to display multiple links between nodes in a non-overlapping manner.
@hellt
Copy link
Member

hellt commented Nov 20, 2024

had a comment about the way it works in our discord: https://discord.com/channels/860500297297821756/1308463195047858217

* Updated javascript to display multiple links between nodes in a non-overlapping manner.
@hellt hellt merged commit fccc901 into srl-labs:main Dec 12, 2024
67 checks passed
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.36%. Comparing base (c06dd25) to head (99db7ca).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
+ Coverage   51.31%   51.36%   +0.04%     
==========================================
  Files         172      172              
  Lines       16792    16838      +46     
==========================================
+ Hits         8617     8649      +32     
- Misses       7253     7264      +11     
- Partials      922      925       +3     

see 9 files with indirect coverage changes

@hellt hellt changed the title Fix for issue #2224 Display link tags for LAGs more properly Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph feature on Containerlab not showing interface tags correctly
2 participants